Skip to content

docs: add Review MLIR skill - #94

Merged
tetsuo-cpp merged 1 commit into
canonfrom
add-idiomatic-mlir-review-skill
Aug 13, 2026
Merged

docs: add Review MLIR skill#94
tetsuo-cpp merged 1 commit into
canonfrom
add-idiomatic-mlir-review-skill

Conversation

@tetsuo-cpp

@tetsuo-cpp tetsuo-cpp commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a general-purpose Review MLIR skill for reviewing C++ and TableGen code
  • require recommendations to match the codebase's pinned LLVM/MLIR revision
  • guide reviewers to find and verify existing upstream functionality before retaining custom machinery
  • include a focused checklist for ODS, rewrites, conversions, passes, SSA, interfaces, performance, and tests
  • preserve semantic and intentional compatibility surfaces while allowing incidental printing and implementation details to be simplified

Validation

  • git diff --check
  • reloaded workspace skills and confirmed review-mlir is discovered without errors
  • confirmed the skill contains no project-specific references

@tetsuo-cpp tetsuo-cpp changed the title Add idiomatic MLIR review skill docs: add idiomatic MLIR review skill Aug 13, 2026
@tetsuo-cpp tetsuo-cpp changed the title docs: add idiomatic MLIR review skill Add idiomatic MLIR skill Aug 13, 2026
@tetsuo-cpp tetsuo-cpp changed the title Add idiomatic MLIR skill Add Review MLIR skill Aug 13, 2026
@tetsuo-cpp tetsuo-cpp changed the title Add Review MLIR skill docs: add review MLIR skill Aug 13, 2026
@tetsuo-cpp
tetsuo-cpp force-pushed the add-idiomatic-mlir-review-skill branch from ee38ee5 to b3dffe3 Compare August 13, 2026 04:32
@tetsuo-cpp tetsuo-cpp changed the title docs: add review MLIR skill docs: add Review MLIR skill Aug 13, 2026
@tetsuo-cpp
tetsuo-cpp merged commit b99163e into canon Aug 13, 2026
1 check passed
@tetsuo-cpp
tetsuo-cpp deleted the add-idiomatic-mlir-review-skill branch August 13, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant