Skip to content

test: migrate stats/base/dists/arcsine/cdf to ULP-based testing - #13986

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
fiboNacci1163:test/arcsine-cdf
Aug 6, 2026
Merged

test: migrate stats/base/dists/arcsine/cdf to ULP-based testing#13986
kgryte merged 2 commits into
stdlib-js:developfrom
fiboNacci1163:test/arcsine-cdf

Conversation

@fiboNacci1163

@fiboNacci1163 fiboNacci1163 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Resolves a part of #11352 .

Description

What is the purpose of this pull request?

This pull request:

  • Updates relative tolerance tests to ULP based tests.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

n/a

@stdlib-js/reviewers

@fiboNacci1163
test: migrate stats/base/dists/arcsine/cdf to ULP-based testing
000750c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@fiboNacci1163
fiboNacci1163 requested a review from a team August 6, 2026 16:55
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 6, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels Aug 6, 2026
kgryte
kgryte reviewed Aug 6, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/arcsine/cdf/test/test.main.js Outdated
@kgryte
Apply suggestions from code review
d0c1ac8 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added review: 4 and removed review: 5 labels Aug 6, 2026
@stdlib-bot

stdlib-bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Aug 6, 2026
@kgryte
kgryte merged commit 7b64d86 into stdlib-js:develop Aug 6, 2026
60 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 4 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fiboNacci1163 @stdlib-bot @kgryte