-
Notifications
You must be signed in to change notification settings - Fork 4
fix(deps): bump python-dotenv to 1.2.2 for VULN-88817 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
911fb5a
ba23658
9f40a3a
cdc6b7d
d8b34f3
db41440
d5cc6f7
ceb6812
d9da534
e510a00
6930c53
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| google-adk>=1.28.1 | ||
| openinference-instrumentation-google-adk | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
| splunk-ao |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ openai | |
| langchain | ||
| langchain-openai | ||
| splunk-ao | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,4 @@ six==1.17.0 | |
| typing_extensions==4.12.2 | ||
| urllib3==2.7.0 | ||
| yarl==1.18.3 | ||
| python-dotenv>=1.0.0 | ||
| python-dotenv>=1.2.2 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| opentelemetry-api | ||
| opentelemetry-exporter-otlp | ||
| opentelemetry-sdk | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
| strands-agents | ||
| strands-agents-tools |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # Core dependencies | ||
| fastapi | ||
| uvicorn | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (documentation): As above: this pin requires Python 3.10+, but this example's tutorial still advertises 3.8 in four places — Worth noting 🤖 Generated by the Astra agent |
||
| jinja2 | ||
| pydantic | ||
| rich>=13.0.0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| python-dotenv>=1.0.0 | ||
| python-dotenv>=1.2.2 | ||
| elevenlabs>=1.0.0 | ||
| splunk-ao | ||
| pyaudio>=0.2.14 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| anthropic | ||
| splunk-ao | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
| pytest |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| azure-ai-inference | ||
| splunk-ao | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
| pytest |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| splunk-ao[openai] | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 | ||
| pytest |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| splunk-ao | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| splunk-ao[openai] | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| splunk-ao | ||
| python-dotenv>=1.0.0 | ||
| python-dotenv>=1.2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Core dependencies | ||
| python-dotenv==1.1.1 | ||
| python-dotenv==1.2.2 | ||
| pydantic==2.11.9 | ||
|
|
||
| # HTTP and Web Framework | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| anthropic | ||
| splunk-ao | ||
| mcp>=1.27.2,<2 | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| splunk-ao | ||
| python-dotenv | ||
| python-dotenv>=1.2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,5 +22,5 @@ yarl==1.18.3 | |
| faiss-cpu>=1.7.4 | ||
| sentence-transformers>=2.5.1 | ||
| numpy>=1.24.0 # Required by FAISS and sentence-transformers | ||
| python-dotenv>=1.0.0 # Added for dotenv support | ||
| python-dotenv>=1.2.2 # Added for dotenv support | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (documentation): This pin now requires Python 3.10+, but 🤖 Generated by the Astra agent |
||
| datasets>=2.18.0 # Added for loading example datasets | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -378,7 +378,7 @@ python-dateutil==2.9.0.post0 | |||||||||||||||||||||||||
| # via | ||||||||||||||||||||||||||
| # botocore | ||||||||||||||||||||||||||
| # google-cloud-bigquery | ||||||||||||||||||||||||||
| python-dotenv==1.0.1 | ||||||||||||||||||||||||||
| python-dotenv==1.2.2 | ||||||||||||||||||||||||||
| # via pydantic-settings | ||||||||||||||||||||||||||
|
Comment on lines
+381
to
382
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (other): This compiled file appears to have been hand-edited rather than regenerated from the updated
If Suggest re-running
Suggested change
🤖 Generated by the Astra agent
Comment on lines
+381
to
382
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (other): This compiled file looks hand-edited rather than regenerated, so it is now out of sync with its source.
The version pin is correct, so nothing installs wrong today. The cost is that the next genuine
Suggested change
🤖 Generated by the Astra agent |
||||||||||||||||||||||||||
| pyyaml==6.0.2 | ||||||||||||||||||||||||||
| # via | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -60,6 +60,7 @@ opentelemetry-api = "^1.38.0" | |||||||
| opentelemetry-exporter-otlp-proto-http = "^1.38.0" | ||||||||
| filelock = ">=3.20.1" | ||||||||
| idna = ">=3.15,<4" | ||||||||
| python-dotenv = ">=1.2.2" | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This lower bound only fixes the root Useful? React with 👍 / 👎.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already addressed in the current head ( The underlying concern about non-root manifests is valid, though, and is still live for other paths — most importantly
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirming this is resolved at the current head: The follow-up concern about non-root manifests is also resolved for the path called out:
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (question): I see this matches an existing convention here ( Also worth a thought: unlike the adjacent 🤖 Generated by the Astra agent
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Independently confirmed the factual premise: On the concrete, non-blocking part of the ask — the explanatory comment — that suggestion has effectively been accepted elsewhere in this same PR but not here: On the upper-bound point: I would not add one. A
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 minor (documentation): The explanatory comment convention introduced in this PR was applied in one place but not the other two.
This matters more than usual because the entry is genuinely not a real dependency: I confirmed Applying the identical comment in both manifests costs nothing and makes the treatment consistent across the PR.
Suggested change
🤖 Generated by the Astra agent |
||||||||
| requests = ">=2.33.0" | ||||||||
| uv = { version = ">=0.9.6", optional = true, python = ">=3.11,<3.14" } | ||||||||
| mcp = { version = ">=1.27.2,<2", optional = true } | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 minor (bug):
python-dotenv1.2.x raises its floor toRequires-Python >=3.10(the rootpoetry.lockdiff shows this:python-versionswent>=3.9→>=3.10). This example advertises and gates on older interpreters:README.md:222— "Ensure you're using Python 3.8+"TUTORIAL.md:31— "Check Python version (should be 3.8+)"start.sh:17—required_version="3.8", exits only below 3.8start.bat:11— "Please install Python 3.8+"So on Python 3.8/3.9
start.shnow passes its version gate and thenpip install -r requirements.txtfails to resolve. Either bump the documented/enforced floor to 3.10 in those four places, or leave this pin at a 1.1.x-compatible value and note the example as out of scope for the CVE. (README.md:49and:283already say 3.10+, so the docs are self-inconsistent today — worth settling on one number while you're here.)🤖 Generated by the Astra agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This concern is valid and only partially addressed by the subsequent commits.
The four spots named here were fixed (
README.md:222,TUTORIAL.md:31,start.sh:11,17,20,start.bat:11), and the author chose the "bump the floor to 3.10" option. But the actual enforcement logic intest_setup.py:18was missed — only its message string was changed to "3.10+", while the comparison still readspy_version.minor < 8. So the specific failure mode described here still reproduces, just via a different entry point: on 3.9,test_setup.pyreports✅ Python 3.9.x is compatibleand then blames a missingpython-dotenv. Commented inline.One refinement on the chosen number: 3.10 satisfies
python-dotenv, butrequirements.txt:8pulls insplunk-ao, whoserequires-pythonis>=3.11,<3.15. So this example is arguably 3.11+, not 3.10+, and picking 3.10 leaves a narrow band (exactly 3.10) that passes every gate and still fails to install. Worth settling on 3.11 across all five files.