Remove base_dir usage for temp_audio_dir to fix incorrect temp file location - #289
Open
mrickar wants to merge 1 commit into
Open
Remove base_dir usage for temp_audio_dir to fix incorrect temp file location#289mrickar wants to merge 1 commit into
base_dir usage for temp_audio_dir to fix incorrect temp file location#289mrickar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Previously,
base_dir = os.path.abspath(os.path.dirname(__file__))was joined withtemp_audio_dir, causing temporary files to be created inside the installed library package:This problem appears when the project is installed via pip (and lives under
site-packages), since temporary files are then placed inside the library package directory instead of an external temp directory.This led to two issues:
temp_audio_dir:setting inconversation_config.yamlwas misleading, because the code automatically prefixed it withbase_dir, making the actual storage location different from what was configured.This PR removes the
base_dirusage so thattemp_audio_dircorrectly reflects the path defined inconversation_config.yamland ensures temporary files are placed in the intended external directory.Impact:
conversation_config.yamlbehaves as expected