fix(tables): allow unbounded v1 row queries - #6713
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview The row-query drain loop in Block param parsing, API Zod schemas ( Reviewed by Cursor Bugbot for commit e1d13ff. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR makes first-party v1 Query Rows requests unbounded when Limit is omitted while retaining validation, bounded database batches, and the 5MB response budget.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/rows/service.ts | Replaces the fixed iteration ceiling with an exhaustion-, limit-, or byte-budget-driven drain whose pagination state advances on every continuing iteration. |
| apps/sim/lib/api/contracts/tables.ts | Introduces a shared optional positive-integer limit schema without a maximum for the intended first-party query contracts. |
| apps/sim/app/api/table/[tableId]/rows/route.ts | Disables execution-sidecar loading for omitted or formerly over-limit queries while preserving total-count behavior. |
| apps/sim/blocks/blocks/table.ts | Preserves omitted Query Rows limits, validates numeric inputs strictly, and keeps bulk-operation limits capped. |
| apps/sim/lib/table/tests/service-filter-threading.test.ts | Adds regression coverage proving an under-budget query can drain beyond the former 1,000-batch ceiling. |
Reviews (6): Last reviewed commit: "fix(tables): always return query totals" | Re-trigger Greptile
|
@cursor review |
31e746d to
a113e08
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a113e08. Configure here.
a113e08 to
16c2831
Compare
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0d74b08. Configure here.
0d74b08 to
e1d13ff
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e1d13ff. Configure here.
Summary
Type of Change
Testing
Checklist