Skip to content

fix(workspaces): give the pin and options button one shared slot - #6402

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/workspace-pin-slot
Aug 8, 2026
Merged

fix(workspaces): give the pin and options button one shared slot#6402
waleedlatif1 merged 1 commit into
stagingfrom
fix/workspace-pin-slot

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to feat(workspaces): pin workspaces and widen the switcher to six rows #6397. The pin glyph sat inline before an always-reserved 18px options button, so a pinned row's name lost ~18px of truncation budget — pinning visibly re-truncated the name at the moment of the click, and hovering showed the pin and the together
  • Match the chat rows (sidebar.tsx): one fixed 18px slot with both children absolutely positioned, the pin fading out as the options button fades in. Trailing width is now constant, so pinning cannot reflow the name
  • Options glyph moves to --text-icon, the canonical icon token its new sibling already uses

Type of Change

  • Bug fix

Testing

Type-check, lint, all 22 audits, and the workspace-header suite pass. Not browser-verified — worth a look at a pinned row on hover.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The pin sat inline before an always-reserved 18px options button, so a pinned
row's name lost ~18px of truncation budget — pinning visibly re-truncated the
name at the moment of the click, and hovering showed pin and options together.

Match the chat rows: one fixed 18px slot with both absolutely positioned, the
pin fading out as the button fades in. The trailing width is now constant, so
pinning cannot reflow the name. The options glyph moves to --text-icon, the
canonical icon token its new sibling already uses.
@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 8, 2026 3:47am

Request Review

@cursor

cursor Bot commented Aug 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only layout and styling in the workspace switcher list; no auth, data, or API changes.

Overview
Fixes a layout bug in workspace switcher rows where the pin and ⋯ options button sat inline, so pinning added ~18px and re-truncated the name at click time; on hover both icons could show together.

The trailing area now uses a single fixed 18px slot (same pattern as chat rows in sidebar.tsx): pin and options are absolutely positioned in that slot, with the pin fading out on row hover or when the context menu is open as the options control fades in. Trailing width stays constant, so pinning no longer reflows the label.

The options icon color moves from --text-tertiary to --text-icon to match the pin.

Reviewed by Cursor Bugbot for commit ce47b5a. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consolidates each workspace row’s pin indicator and options button into one fixed-width slot so pinning no longer changes the workspace-name truncation.

  • Absolutely positions the pin and options controls within a shared 18px container.
  • Cross-fades the pin and options glyph based on row hover and menu-open state.
  • Updates the options glyph to use the canonical --text-icon token.

Confidence Score: 5/5

The PR appears safe to merge, with the workspace-row hover and menu-open states remaining consistent after the layout adjustment.

The row’s existing chip classes provide the required hover group, and the new fixed slot correctly swaps pin and options visibility without changing the row width or menu handlers.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx The shared trailing slot preserves row width while retaining the existing context-menu behavior; no actionable regression was identified.

Reviews (1): Last reviewed commit: "fix(workspaces): give the pin and option..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit cb8338c into staging Aug 8, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/workspace-pin-slot branch August 8, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant