fix(workspaces): give the pin and options button one shared slot - #6402
Conversation
The pin sat inline before an always-reserved 18px options button, so a pinned row's name lost ~18px of truncation budget — pinning visibly re-truncated the name at the moment of the click, and hovering showed pin and options together. Match the chat rows: one fixed 18px slot with both absolutely positioned, the pin fading out as the button fades in. The trailing width is now constant, so pinning cannot reflow the name. The options glyph moves to --text-icon, the canonical icon token its new sibling already uses.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The trailing area now uses a single fixed 18px slot (same pattern as chat rows in The options icon color moves from Reviewed by Cursor Bugbot for commit ce47b5a. Configure here. |
Greptile SummaryThe PR consolidates each workspace row’s pin indicator and options button into one fixed-width slot so pinning no longer changes the workspace-name truncation.
Confidence Score: 5/5The PR appears safe to merge, with the workspace-row hover and menu-open states remaining consistent after the layout adjustment. The row’s existing chip classes provide the required hover group, and the new fixed slot correctly swaps pin and options visibility without changing the row width or menu handlers.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx | The shared trailing slot preserves row width while retaining the existing context-menu behavior; no actionable regression was identified. |
Reviews (1): Last reviewed commit: "fix(workspaces): give the pin and option..." | Re-trigger Greptile
Summary
…togethersidebar.tsx): one fixed 18px slot with both children absolutely positioned, the pin fading out as the options button fades in. Trailing width is now constant, so pinning cannot reflow the name--text-icon, the canonical icon token its new sibling already usesType of Change
Testing
Type-check, lint, all 22 audits, and the workspace-header suite pass. Not browser-verified — worth a look at a pinned row on hover.
Checklist