Skip to content

fix: SeamEvent union type by removing generic event resource #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razor-x merged 2 commits into from
Aug 14, 2026
+15 −135
Merged

fix: SeamEvent union type by removing generic event resource #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53aec36
fix: Make SeamEvent a discriminated union
claude Aug 14, 2026
e8bdf10
fix: Widen discriminated resource type set for lookup
claude Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion codegen/lib/layouts/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,19 @@ export const getResourceTypeName = (resourceType: string): string =>
export const getResourceLayoutContexts = (
blueprint: Blueprint,
): ResourceLayoutContext[] => {
// Events and action attempts are discriminated unions built from the
// top-level blueprint collections. The generic resources sharing those
// resource types have all-optional properties, and including one as a union
// member would defeat narrowing on the discriminant.
const discriminatedResourceTypes = new Set<string>(
[...blueprint.events, ...blueprint.actionAttempts].map(
({ resourceType }) => resourceType,
),
)
const resources = [
...blueprint.resources,
...blueprint.resources.filter(
({ resourceType }) => !discriminatedResourceTypes.has(resourceType),
),
...blueprint.events,
...blueprint.actionAttempts,
]
Expand Down
137 changes: 3 additions & 134 deletions src/lib/resources/event.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading