Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegen/layouts/partials/route-class-endpoint.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{methodName}}
{{> endpont-method-signature }}
{
assertValidRequestParameters(parameters, '{{path}}', {{hasRequiredParameters}})
assertValidRequestParameters(parameters, '{{path}}', {{hasRequiredParameters}}, [{{#each requiredParameterNames}}{{json .}}{{#unless @last}}, {{/unless}}{{/each}}])

return new SeamHttpRequest(this, {
pathname: '{{path}}',
Expand Down
4 changes: 4 additions & 0 deletions codegen/lib/layouts/route.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export interface EndpointLayoutContext {
returnsVoid: boolean
isOptionalParamsOk: boolean
hasRequiredParameters: boolean
requiredParameterNames: string[]
requiresAtLeastOneParameter: boolean
parameters: Parameter[]
responseIsList: boolean
Expand Down Expand Up @@ -149,6 +150,9 @@ export const getEndpointLayoutContext = (
requestTypeName: `${prefix}Request`,
isOptionalParamsOk: !endpoint.request.hasRequiredParameters,
hasRequiredParameters: endpoint.request.hasRequiredParameters,
requiredParameterNames: endpoint.request.parameters
.filter(({ isRequired }) => isRequired)
.map(({ name }) => name),
requiresAtLeastOneParameter: requiresAtLeastOneParameter(endpoint),
parameters: endpoint.request.parameters,
responseIsList: endpoint.response.responseType === 'resource_list',
Expand Down
13 changes: 12 additions & 1 deletion src/lib/request-parameters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const assertValidRequestParameters = (
parameters: unknown,
path: string,
hasRequiredParameters: boolean,
requiredParameterNames: string[],
): void => {
if (parameters === undefined) {
if (hasRequiredParameters) {
Expand All @@ -25,9 +26,19 @@ export const assertValidRequestParameters = (
throw new TypeError(`Parameters for ${path} must be an object`)
}

const parameterValues = parameters as Record<string, unknown>
const missingParameterNames = requiredParameterNames.filter(
(name) => parameterValues[name] === undefined,
)
if (missingParameterNames.length > 0) {
throw new TypeError(
`Required parameters missing for ${path}: ${missingParameterNames.join(', ')}`,
)
}

if (
hasRequiredParameters &&
Object.values(parameters).every((value) => value === undefined)
Object.values(parameterValues).every((value) => value === undefined)
) {
throw new TypeError(`At least one parameter is required for ${path}`)
}
Expand Down
21 changes: 16 additions & 5 deletions src/lib/routes/access-codes/access-codes.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/lib/routes/access-codes/simulate/simulate.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/lib/routes/access-codes/unmanaged/unmanaged.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 16 additions & 6 deletions src/lib/routes/access-grants/access-grants.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/lib/routes/access-grants/unmanaged/unmanaged.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions src/lib/routes/access-methods/access-methods.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/lib/routes/access-methods/unmanaged/unmanaged.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading