fix: Guard against null response data instead of throwing NullReferenceException - #312
Merged
Merged
Conversation
…ceException Generated API methods dereferenced ApiResponse<T>.Data without checking for null. When a response deserializes to null — an empty or null JSON body, a non-JSON body on a 2xx/3xx status, or a RestSharp deserialization error captured on the response — callers got an opaque NullReferenceException with no HTTP diagnostics. Add ApiResponse<T>.EnsureData(path), which returns the data or throws a SeamException carrying the request path, HTTP status code, response headers, and raw body, and update the codegen route template so every generated endpoint uses it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Ck3swavz8q3cmv52MJ5DL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated API methods dereferenced ApiResponse.Data without checking
for null. When a response deserializes to null — an empty or null JSON
body, a non-JSON body on a 2xx/3xx status, or a RestSharp deserialization
error captured on the response — callers got an opaque
NullReferenceException with no HTTP diagnostics.
Add ApiResponse.EnsureData(path), which returns the data or throws a
SeamException carrying the request path, HTTP status code, response
headers, and raw body, and update the codegen route template so every
generated endpoint uses it.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015Ck3swavz8q3cmv52MJ5DL