fix(admin): distinguish unavailable cluster counts - #343
Merged
Conversation
Co-Authored-By: heihutu <heihutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Problem
rc admin info clusterprints the numericcountfields even when RustFS explicitly marks bucket or object statistics as unavailable. Because unavailable counts are encoded with a zero placeholder plus an error, the human-readable output incorrectly presents unknown values as real zero counts.Solution
unavailablefor bucket and object counts when the corresponding server error is non-empty.Verification
cargo fmt --all --checkcargo test -p rustfs-cli --lib 'commands::admin::info::tests'— 11 passed.cargo test -p rustfs-cli --test admin_info— 4 passed.cargo clippy --workspace -- -D warningscargo test --workspacegit diff --checkAll checks passed.
Impact
Human-readable cluster information no longer misrepresents unavailable bucket and object statistics as empty clusters. Successful counts, exit codes, requests, and JSON output remain compatible.
Additional Notes
The companion server PR allows a complete live bucket namespace count to remain available while the authoritative object and usage snapshot is rebuilding. This CLI PR independently handles unavailable fields from current and older compatible RustFS responses.