test(vscode): cover the rstack config bridge end to end - #9
Merged
Conversation
- Add e2e/rstest/suite/bridge.test.ts: a folder whose only test signal is rstack.config.ts gets a bridged project - explorer tree (node-less layout + AST test cases) and a real run through rstack's shipped shim. - Bump the rstack fixture to rstack@0.5.0-alpha.1 (newest published); move its public-hoist settings from the fixture .npmrc (no longer read by pnpm 11) to shared install flags in setupFixtures.mjs. - Replace the enumerated test:e2e:* script chain with e2e/run.mjs: a SLICES table declares each slice's fixtures and entry, package.json scripts become thin forwards, and tsc compiles first to fail fast. - Record the tools-and-configs vocabulary (atomic tool, Rstack config, shim, bridged project, ownership) in CONTEXT.md.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b00aaf1bbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With shell: true Node concatenates command and args unescaped, so spawning process.execPath or an entry path containing spaces through the shared option would break argument boundaries on Windows. Only the pnpm .cmd shim needs a shell (CVE-2024-27980 hardening); node spawns now run shell-less. Raised by PR review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rstack config bridge (a folder whose only test signal is
rstack.config.*drives Rstest through rstack's shipped shim) was implemented but had no E2E coverage beyond detection. This PR locks it in end to end, against the newest published rstack:e2e/rstest/suite/bridge.test.ts— adds the sharedrstackfixture as a second workspace folder and asserts the bridged project's explorer tree (node-less layout, AST-collected test cases) and a real run through the shim (1 passed), restoring the single-folder state for the suites that follow.e2e/fixtures/rstacknow pinsrstack@0.5.0-alpha.1(newest published; npmlatestis 0.4.0). The version gate already passes prereleases inside a supported range by policy, so no source change. The fixture's.npmrcpublic-hoist settings moved into shared install flags insetupFixtures.mjs— pnpm 11 no longer readspublic-hoist-patternfrom a project-local.npmrc.test:e2e:*script chain is replaced bye2e/run.mjs: aSLICEStable declares each slice's fixtures and entry, package.json scripts become thin forwards (pnpm test:e2e [slice ...]),tsccompiles first to fail fast. CI'spnpm run test:e2eis unaffected.Extension source (
src/) is unchanged.Verified:
pnpm lint,pnpm test:unit, and the full E2E chain (smoke, vscode, rstest, lint) locally green.Related Links
Checklist