Add testcase for services with buffer in the response only - #263
Open
mathias-luedtke wants to merge 1 commit into
Open
Add testcase for services with buffer in the response only#263mathias-luedtke wants to merge 1 commit into
mathias-luedtke wants to merge 1 commit into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Member
|
@adbidwai to take a look |
|
Hi, I can take a look at this. Thanks! |
fujitatomoya
requested changes
Aug 13, 2026
fujitatomoya
left a comment
There was a problem hiding this comment.
I do not think we can take this without fixes, because this generates intentionally red test.
Signed-off-by: Mathias Lüdtke <mathias.luedtke@pal-robotics.com>
mathias-luedtke
force-pushed
the
feature/buffer-test-case
branch
from
August 14, 2026 11:00
26b66a6 to
6222bb3
Compare
Author
I can add the fix as well, but I need to know which option do you prefer (see #264) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add a test case that shows that cpplint checks fail for generated code for services that have buffers in their response, but not in the request.
The same issue should happen for actions.
The tests will fail with:
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
This issue was introduced by #250