[mypyc] Fix function wrapper descriptor for static/class methods - #21811
Open
p-sawicki wants to merge 3 commits into
Open
[mypyc] Fix function wrapper descriptor for static/class methods#21811p-sawicki wants to merge 3 commits into
p-sawicki wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling an
asyncclass method in interpreted context might fail on incorrect number of arguments because the classTon the lhs of the member expressionT.f(a,b,c)is not bound to theclsargument. Instead the first regular argument is taken asclsand all other are shifted.Expand the
tp_descr_getslot of the function wrapper type object to correctly handle class methods.Also modify the function lowering logic to take the method from the type dictionary instead of through
getattrwhen calling a decorator on the method.getattrgoes through the descriptor and binds theclsargument but the argument should be unbound when applying the decorator to match interpreted Python.