gh-155742: Use PyBytesWriter in marshal - #155748
Open
vstinner wants to merge 3 commits into
Open
Conversation
Replace soft deprecated PyBytes_FromStringAndSize() and _PyBytes_Resize() with PyBytesWriter.
No PyBytesWriter is needed.
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
I do not think the current code is broken.
Member
Author
I didn't say that the current code is broken. The PR only just avoids the soft deprecated PyBytes_FromStringAndSize() function. I reworked the error handling. @serhiy-storchaka: Please review the updated PR. |
Member
Author
|
I wrote a script to test manually this PR by injecting import marshal
import io
import _testcapi
obj = b'x' * (1024 * 1024)
file = io.BytesIO()
for i in range(10):
try:
try:
_testcapi.set_nomemory(i)
res = marshal.dump(obj, file)
finally:
_testcapi.remove_mem_hooks()
except Exception as exc:
print(f"marshal.dump failed: {exc!r}")
else:
print(f"{res=}")Before, the code failed with an assertion error. With my latest change, the code works is all cases (always raise MemoryError as expected). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace soft deprecated PyBytes_FromStringAndSize() and _PyBytes_Resize() with PyBytesWriter.