gh-84419: Fix the execute permissions in os.stat() on Windows - #155392
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-84419: Fix the execute permissions in os.stat() on Windows#155392serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
Windows strips trailing dots and spaces from the last component of the path,
so os.stat('spam.bat ') opened the same file as os.stat('spam.bat'), but did
not set the execute permissions in st_mode, because the extension did not
match. They are now ignored, unless the \\?\ prefix disables the path
normalization.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows strips trailing dots and spaces from the last component of the path, so
os.stat('spam.bat ')returns the information about the same file asos.stat('spam.bat'), but the execute permissions were not set inst_mode, because the extension'.bat 'did not match'.bat':Trailing dots and spaces are now ignored, unless the path starts with the
\\?\prefix, which disables the path normalization.This does not fix the difference between
os.stat()andos.scandir()for such paths, which needs a separate change.