gh-78526: Add tests for PEP 468 and PEP 520 - #155387
Open
serhiy-storchaka wants to merge 1 commit into
Open
Conversation
Test that the order of keyword arguments and the order of class attribute definitions are preserved.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were almost no explicit tests for PEP 468 (Preserving Keyword Argument Order) and none for PEP 520 (Preserving Class Attribute Definition Order). Both work now only as a side effect of the dict order, so breaking them in some path would not be detected.
Added tests for the order of keyword arguments in functions, methods and C functions, and for the order of class attribute definitions in the class dict, in the namespace passed to the metaclass and in the mapping returned by
type.__prepare__().