Skip to content

gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst - #152178

Open
lpyu001 wants to merge 4 commits into
python:mainfrom
lpyu001:Fix-all-Sphinx-reference-warnings-in-email
Open

gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst#152178
lpyu001 wants to merge 4 commits into
python:mainfrom
lpyu001:Fix-all-Sphinx-reference-warnings-in-email

Conversation

@lpyu001

@lpyu001 lpyu001 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@lpyu001
lpyu001 requested review from a team, AA-Turner, StanFromIreland and hugovk as code owners June 25, 2026 09:27
@lpyu001 lpyu001 changed the title gh-151947: Fix all Sphinx reference warnings in Doc/library/email.{charset,parse… gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst Jun 25, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 25, 2026

Copy link
Copy Markdown

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitdancer, can you take a glance please when you have a chance?

@StanFromIreland StanFromIreland changed the title gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst Jun 25, 2026
@StanFromIreland

Copy link
Copy Markdown
Member

Ha, the tests pass on this PR. That one really was cursed.

@lpyu001

lpyu001 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

It has been in a merge-ready state for over a month. Could it be merged? @StanFromIreland

@StanFromIreland

Copy link
Copy Markdown
Member

It has been in a merge-ready state for over a month.

There are conflicts. Additionally I'd still like to get one of the email expert's reviews (CC @bitdancer @serhiy-storchaka)

Comment thread Doc/tools/.nitignore Outdated
Doc/library/asyncio-extending.rst
Doc/library/email.charset.rst
Doc/library/email.parser.rst
Doc/library/http.cookiejar.rst

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these added?

Removed email.charset.rst and email.parser.rst from .nitignore
Removed http.cookiejar.rst and http.server.rst from .nitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants