gh-151524: Avoid using instrumentation callback result after Py_DECREF by lpyu001 · Pull Request #151525 · python/cpython

lpyu001 · 2026-06-16T02:48:09Z

Issue: instrumentation.c: Use-after-Py_DECREF comparison in call_one_instrument #151524

…_DECREF

chris-eibl

The change lgtm, but I'd create a news entry, like almost all of the fixes for the umbrella issue #146102 did so far.

bedevere-app · 2026-06-16T05:42:01Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

lpyu001 · 2026-06-16T06:05:28Z

The change lgtm, but I'd create a news entry, like almost all of the fixes for the umbrella issue #146102 did so far.

cc @pablogsal

I’ve submitted the news entry.thanks

sobolevn

Question: was it ever tested? Or was just the RC of res higher than 1, so no crash happened?

sobolevn · 2026-06-16T07:41:54Z

@@ -0,0 +1,2 @@
+Avoid comparing the result of a ``sys.monitoring`` callback after


This would be a user-facing news entry. Users care about crashes (which could happen here), not about RC :)
Let's rephrase it.

ZeroIntensity

This isn't UB. _PyInstrumentation_DISABLE is an immortal object; Py_DECREF operations on it are a no-op.

>>> import sys
>>> sys._is_immortal(sys.monitoring.DISABLE)
True

That said, I do agree that it's misleading. Let's either remove the Py_DECREF call entirely and/or add an assertion that it's immortal.

bedevere-app · 2026-06-16T09:41:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

aisk · 2026-07-21T16:27:32Z

Hi @lpyu001 I see you made some update on this PR, and currently I think it look fine. Can you reply "I have made the requested changes; please review again" in the comments as the bot said, to require other reviewers continue the work?

lpyu001 · 2026-07-22T01:18:46Z

I have made the requested changes; please review again

bedevere-app · 2026-07-22T01:18:53Z

Thanks for making the requested changes!

@chris-eibl, @ZeroIntensity: please review the changes made to this pull request.

chris-eibl

Lgtm and helps me who didn't realize _PyInstrumentation_DISABLE is immortal 👍

lpyu001 · 2026-08-07T09:46:05Z

The PR has been mergeable for two weeks. Could we go ahead and merge it? @ZeroIntensity @chris-eibl

miss-islington-app · 2026-08-07T15:34:56Z

Thanks @lpyu001 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2026-08-07T15:34:56Z

Thanks @lpyu001 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

miss-islington-app · 2026-08-07T15:34:56Z

Thanks @lpyu001 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

bedevere-app · 2026-08-07T15:35:10Z

GH-155349 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2026-08-07T15:35:18Z

GH-155350 is a backport of this pull request to the 3.15 branch.

bedevere-app · 2026-08-07T15:35:25Z

GH-155351 is a backport of this pull request to the 3.13 branch.

…s immortal in the code (GH-151525) (GH-155351) (cherry picked from commit 52bed26) Co-authored-by: stevens <lipengyu@kylinos.cn>

…s immortal in the code (GH-151525) (GH-155349) (cherry picked from commit 52bed26) Co-authored-by: stevens <lipengyu@kylinos.cn>

bedevere-bot · 2026-08-07T17:15:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan Debug 3.13 (tierless) has failed when building commit 2e19855.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1439/builds/1152) and take a look at the build logs.
Check if the failure is related to this commit (2e19855) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1439/builds/1152

Failed tests:

test_io

Failed subtests:

test_daemon_threads_shutdown_stdout_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stdout_deadlock
test_daemon_threads_shutdown_stderr_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stderr_deadlock

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4755, in test_daemon_threads_shutdown_stderr_deadlock
    self.check_daemon_threads_shutdown_deadlock('stderr')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4743, in check_daemon_threads_shutdown_deadlock
    self.assertRegex(err, pattern)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
AssertionError: Regex didn't match: "Fatal Python error: _enter_buffered_busy: could not acquire lock for <(_io\\.)?BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads" not found in '...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................


Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4755, in test_daemon_threads_shutdown_stderr_deadlock
    self.check_daemon_threads_shutdown_deadlock('stderr')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4743, in check_daemon_threads_shutdown_deadlock
    self.assertRegex(err, pattern)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
AssertionError: Regex didn't match: "Fatal Python error: _enter_buffered_busy: could not acquire lock for <(_io\\.)?BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads" not found in '....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................


Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4750, in test_daemon_threads_shutdown_stdout_deadlock
    self.check_daemon_threads_shutdown_deadlock('stdout')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_io.py", line 4743, in check_daemon_threads_shutdown_deadlock
    self.assertRegex(err, pattern)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^

bedevere-bot · 2026-08-07T17:36:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Usan Function 3.13 (tierless) has failed when building commit 2e19855.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1601/builds/821) and take a look at the build logs.
Check if the failure is related to this commit (2e19855) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1601/builds/821

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '2e19855a1734a47780b42cfcdc9e3f31976c3e7c'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2e19855a1734a [3.13] gh-151524: Make it clearer that `_PyInstrumentation_DISABLE` is immortal in the code (GH-151525) (GH-155351)
Switched to and reset branch '3.13'

rror: unable to open output file 'Python/pythonrun.o': 'No space left on device'
1 error generated.
make: *** [Makefile:3042: Python/pythonrun.o] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:3132: clean-retain-profile] Error 1 (ignored)

…s immortal in the code (GH-151525) (#155350) gh-151524: Make it clearer that `_PyInstrumentation_DISABLE` is immortal in the code (GH-151525) (cherry picked from commit 52bed26) Co-authored-by: stevens <lipengyu@kylinos.cn>

pythongh-151524: Avoid using instrumentation callback result after Py…

a4cc0af

…_DECREF

bedevere-app Bot added the awaiting review label Jun 16, 2026

bedevere-app Bot mentioned this pull request Jun 16, 2026

instrumentation.c: Use-after-Py_DECREF comparison in call_one_instrument #151524

Closed

chris-eibl self-requested a review June 16, 2026 05:28

chris-eibl requested changes Jun 16, 2026

View reviewed changes

bedevere-app Bot added awaiting changes and removed awaiting review labels Jun 16, 2026

add NEWS

137a1bf

chris-eibl approved these changes Jun 16, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting changes labels Jun 16, 2026

sobolevn reviewed Jun 16, 2026

View reviewed changes

ZeroIntensity requested changes Jun 16, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-13-50-13.gh-issue-151377.mCqrGg.rst Outdated

bedevere-app Bot added awaiting changes and removed awaiting merge labels Jun 16, 2026

ZeroIntensity added the skip news label Jun 16, 2026

update

67821dc

bedevere-app Bot added awaiting change review and removed awaiting changes labels Jul 22, 2026

bedevere-app Bot requested review from ZeroIntensity and chris-eibl July 22, 2026 01:18

chris-eibl approved these changes Jul 23, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting change review labels Jul 23, 2026

ZeroIntensity approved these changes Jul 23, 2026

View reviewed changes

aisk approved these changes Aug 7, 2026

View reviewed changes

ZeroIntensity merged commit 52bed26 into python:main Aug 7, 2026
56 of 59 checks passed

bedevere-app Bot removed the awaiting merge label Aug 7, 2026

ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 7, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 7, 2026

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 7, 2026

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 7, 2026

ZeroIntensity pushed a commit that referenced this pull request Aug 7, 2026

[3.13] gh-151524: Make it clearer that _PyInstrumentation_DISABLE i…

2e19855

…s immortal in the code (GH-151525) (GH-155351) (cherry picked from commit 52bed26) Co-authored-by: stevens <lipengyu@kylinos.cn>

ZeroIntensity pushed a commit that referenced this pull request Aug 7, 2026

[3.14] gh-151524: Make it clearer that _PyInstrumentation_DISABLE i…

87bacf1

…s immortal in the code (GH-151525) (GH-155349) (cherry picked from commit 52bed26) Co-authored-by: stevens <lipengyu@kylinos.cn>

		@@ -0,0 +1,2 @@
		Avoid comparing the result of a ``sys.monitoring`` callback after

Uh oh!

Uh oh!

Conversation

lpyu001 commented Jun 16, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chris-eibl left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app Bot commented Jun 16, 2026

Uh oh!

lpyu001 commented Jun 16, 2026

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

sobolevn Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-app Bot commented Jun 16, 2026

Uh oh!

aisk commented Jul 21, 2026

Uh oh!

lpyu001 commented Jul 22, 2026

Uh oh!

bedevere-app Bot commented Jul 22, 2026

Uh oh!

chris-eibl left a comment

Choose a reason for hiding this comment

Uh oh!

lpyu001 commented Aug 7, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Aug 7, 2026

Uh oh!

miss-islington-app Bot commented Aug 7, 2026

Uh oh!

miss-islington-app Bot commented Aug 7, 2026

Uh oh!

bedevere-app Bot commented Aug 7, 2026

Uh oh!

bedevere-app Bot commented Aug 7, 2026

Uh oh!

bedevere-app Bot commented Aug 7, 2026

Uh oh!

bedevere-bot commented Aug 7, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 7, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lpyu001 commented Jun 16, 2026 •

edited by bedevere-app Bot

Loading