Skip to content

gh-77842: Clear Authorization header when redirect to cross-site - #11292

Open
kyoshidajp wants to merge 5 commits into
python:mainfrom
kyoshidajp:bpo-33661
Open

gh-77842: Clear Authorization header when redirect to cross-site#11292
kyoshidajp wants to merge 5 commits into
python:mainfrom
kyoshidajp:bpo-33661

Conversation

@kyoshidajp

@kyoshidajp kyoshidajp commented Dec 23, 2018

Copy link
Copy Markdown

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://bugs.python.org/msg317793. The problem is that both authorization and cookies are sent on the redirect. Here I don't see the filter for Cookies. That is not necessary?

@kyoshidajp

Copy link
Copy Markdown
Author

@eamanu Thanks. It slipped my mind. I will add it. BTW, should I add other sensitive headers (WWW-Authenticate, Cookie2), too?

@eamanu

eamanu commented Dec 24, 2018

Copy link
Copy Markdown
Contributor

@eamanu Thanks. It slipped my mind. I will add it. BTW, should I add other sensitive headers (WWW-Authenticate, Cookie2), too?

I will put it in bugs.python for discuss

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2025
@bedevere-app

bedevere-app Bot commented Aug 11, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

The origin includes the scheme, so credentials are no longer sent if the
connection is downgraded from HTTPS to HTTP.
@serhiy-storchaka serhiy-storchaka added type-security A security issue needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed stale Stale PR or inactive for long period of time. labels Aug 12, 2026

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added NEWS and added scheme to comparison. LGTM now. 👍 Thank you for your contribution @kyoshidajp.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 12, 2026
@serhiy-storchaka serhiy-storchaka changed the title bpo-33661: Clear Authorization header when redirect to cross-site gh-77842: Clear Authorization header when redirect to cross-site Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants