Fix #562: default task missing positionals raises ParseError - #1082
Open
DSeaStar wants to merge 1 commit into
Open
Fix #562: default task missing positionals raises ParseError#1082DSeaStar wants to merge 1 commit into
DSeaStar wants to merge 1 commit into
Conversation
The default-task fallback skipped the parser, so a custom Program (or inv with no argv) leaked a traceback instead of the usual ParseError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executor.normalizeused to call that task with no arguments. Required positionals then failed inside the task body as aTypeErrortraceback (customProgrambinaries, orinvwith no argv).ParseError, soProgram.runprints the familiar'task' did not receive required positional arguments: 'arg'message and exits 1.Fixes #562.
Test plan
Executor.execute()with a default task missing a required positional raisesParseError(notTypeError)Program.run("myapp")with that collection prints the parser-style error on stderrdefault_tasks_called_when_no_tasks_specified(Mock body /*args, **kwargs) still passes