Implement unicode support for lazily encoding strings - #1246
Open
Vizonex wants to merge 1 commit into
Open
Conversation
Member
|
KDFs operate over byte strings, unless the KDF itself defines an encoding for strings, I think offering this API is a mistake, because it misleads users into not understanding what level of abstraction things operate at. The extremely modest inconveience of having to encode your string is worth it to keep thing conceptually correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I've come across when using this library is wanting to make things easier for users
hashpw(password.encode('utf-8'), ...)can be rather annoying and I hope this PR tries to optimize some of the brokenness with unicode support. I'm sure the example I've given logically illustrates what I am after.