Skip to content

Note that Makefile is cookiecutter-managed - #1456

Draft
gerrod3 wants to merge 2 commits into
pulp:mainfrom
gerrod3:cookie-make-note
Draft

Note that Makefile is cookiecutter-managed#1456
gerrod3 wants to merge 2 commits into
pulp:mainfrom
gerrod3:cookie-make-note

Conversation

@gerrod3

@gerrod3 gerrod3 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This is the behavior we want, right?

@@ -1,4 +1,6 @@
{%- set src_infix = "src/" if cookiecutter.src_layout else "" %}
# This file is managed by cookiecutter. Any changes should originate in the template and be applied through cookiecutter/apply_templates.py.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of this in the pyproject.toml, because it's rather unintuitive there.
# This section is managed by the cookiecutter templates.

I would keep the language similar:

Suggested change
# This file is managed by cookiecutter. Any changes should originate in the template and be applied through cookiecutter/apply_templates.py.
# This file is managed by the cookiecutter templates.

or

Suggested change
# This file is managed by cookiecutter. Any changes should originate in the template and be applied through cookiecutter/apply_templates.py.
# This file is managed by the cookiecutter templates.
# Do not edit manually.

Should we make that a macro and add to more files?
The whole .ci directory for example should be managed, but at the moment we don't delete additional files there.
The .github/workflows/test.yaml is extra-special. It is templated but keeps the test matrix intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants