ext/snmp: Put XFAILs under SKIPIF section in tests - #23237
Conversation
LamentXU123
changed the title
is_flaky_output in flaky SNMP tests
LamentXU123
changed the title
is_flaky_output in flaky SNMP tests
| 'connection refused', | ||
| 'deadlock', | ||
| 'mailbox already exists', | ||
| 'no response from', |
There was a problem hiding this comment.
Could we add a comment why it was added? Harder to follow via git history. Ideally the list shrinks to zero later; most of it sounds like concurrency stuff which we eventually might rather want to find root causes instead of adding retry overhead.
There was a problem hiding this comment.
Talking to external services is inherently flaky.
There was a problem hiding this comment.
Doesn't mean it's the sole reason. Still think adding a comment why, as in which context, it was deemed necessary to add makes sense.
There was a problem hiding this comment.
Not in this case, but the repeat mechanism was added for a reason. We are still struggling with intermittent failures even with it.
There was a problem hiding this comment.
Sure, I didn't say remove the mechanism, just that the list ideally shrinks to zero. :)
|
Well, from https://github.com/php/php-src/actions/runs/31686010402/job/94402180515 we can see the retry mechanism doesn't work well. The tests still possibly fails. |
|
Sigh. I'm ok with a |
LamentXU123
changed the title
3 participants
This adds the SNMP retry pattern to
is_flaky_outputto retry SNMP tests when it fails.This also removes the XFAIL section in SNMP tests.
Note: only snmp tests use the
No response from ...prefix