Skip to content

[%pS migration] Use %pS in ext/xmlreader #23174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DanielEScherzer wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[%pS migration] Use %pS in ext/xmlreader #23174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/xmlreader/php_xmlreader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ void xmlreader_unset_property(zend_object *object, zend_string *name, void **cac
xmlreader_prop_handler *hnd = xmlreader_get_prop_handler(name, cache_slot);

if (hnd != NULL) {
zend_throw_error(NULL, "Cannot unset %s::$%s", ZSTR_VAL(object->ce->name), ZSTR_VAL(name));
zend_throw_error(NULL, "Cannot unset %pS::$%pS", object->ce->name, name);
return;
}

Expand Down Expand Up @@ -1282,7 +1282,7 @@ PHP_METHOD(XMLReader, expand)
/* Note: cannot use NODE_GET_OBJ here because of the wrong return type */
domobj = Z_LIBXML_NODE_P(basenode);
if (UNEXPECTED(domobj->node == NULL)) {
php_error_docref(NULL, E_WARNING, "Couldn't fetch %s", ZSTR_VAL(Z_OBJCE_P(basenode)->name));
php_error_docref(NULL, E_WARNING, "Couldn't fetch %pS", Z_OBJCE_P(basenode)->name);
RETURN_FALSE;
}
node = domobj->node->node;
Expand Down
Loading