Skip to content

[%pS migration] Use %pS in ext/xml #23173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DanielEScherzer wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Draft

[%pS migration] Use %pS in ext/xml #23173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/xml/xml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ static bool php_xml_check_string_method_arg(
zend_function *method_ptr = zend_hash_find_ptr_lc(&ce->function_table, method_name);
if (!method_ptr) {
if (arg_num) {
zend_argument_value_error(arg_num, "method %s::%s() does not exist", ZSTR_VAL(ce->name), ZSTR_VAL(method_name));
zend_argument_value_error(arg_num, "method %pS::%pS() does not exist", ce->name, method_name);
}
return false;
}
Expand All @@ -1170,8 +1170,8 @@ static bool php_xml_check_string_method_arg(
zend_fcc_dtor(&parser_to_check->fcc_field); \
bool status = php_xml_check_string_method_arg(0, new_this_obj, method_name, &parser_to_check->fcc_field); \
if (status == false) { \
zend_argument_value_error(2, "cannot safely swap to object of class %s as method \"%s\" does not exist, which was set via " handler_set_method, \
ZSTR_VAL(new_this_obj->ce->name), ZSTR_VAL(method_name)); \
zend_argument_value_error(2, "cannot safely swap to object of class %pS as method \"%pS\" does not exist, which was set via " handler_set_method, \
new_this_obj->ce->name, method_name); \
zend_string_release(method_name); \
RETURN_THROWS(); \
} \
Expand Down
Loading