-
Notifications
You must be signed in to change notification settings - Fork 242
next (v5.6; do not mege) #3474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
next (v5.6; do not mege) #3474
Changes from all commits
fbce8b2
7e5a900
3fecf20
873eca1
0ddecbd
eb7958d
fffe39c
9e5927a
8ad1115
14912ba
510e173
907fe61
9272c99
aa809d4
db9a0fa
592bad3
d4bd3da
b5022e2
484727d
51490a2
9010df1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ public class MyReconciler implements Reconciler<TestCustomResource> { | |
| InformerEventSource<ConfigMap, TestCustomResource> configMapES = | ||
| new InformerEventSource<>(InformerEventSourceConfiguration.from(ConfigMap.class, TestCustomResource.class) | ||
| .withNamespacesInheritedFromController(context) | ||
| .build(), context); | ||
| .build()); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
if rg -n --glob '*.md' 'withNamespacesInheritedFromController\(context\)' docs/content/en/docs; then
echo "Found a stale context argument."
exit 1
fiRepository: operator-framework/java-operator-sdk Length of output: 332 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- documentation context ---'
sed -n '65,100p' docs/content/en/docs/documentation/operations/configuration.md
printf '%s\n' '--- API declarations and usages ---'
rg -n -g '*.java' -g '*.md' 'withNamespacesInheritedFromController' .
printf '%s\n' '--- candidate source files ---'
fd -t f -e java | rg 'InformerEventSourceConfiguration|Configuration'
printf '%s\n' '--- change summary ---'
git diff --stat
git status --shortRepository: operator-framework/java-operator-sdk Length of output: 6521 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- InformerEventSourceConfiguration builder ---'
sed -n '180,235p' operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java
printf '%s\n' '--- related InformerConfiguration builder method ---'
sed -n '425,470p' operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
printf '%s\n' '--- documentation examples using the helper ---'
rg -n -C 2 --glob '*.md' 'withNamespacesInheritedFromController' docs/content/en/docsRepository: operator-framework/java-operator-sdk Length of output: 4652 🏁 Script executed: python3 - <<'PY'
import re
from pathlib import Path
source = Path("operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java").read_text()
docs = list(Path("docs/content/en/docs").rglob("*.md"))
declarations = re.findall(
r"public\s+Builder<[^>]+>\s+withNamespacesInheritedFromController\s*\(([^)]*)\)",
source,
)
calls = []
for path in docs:
text = path.read_text()
for match in re.finditer(r"\.withNamespacesInheritedFromController\s*\(([^)]*)\)", text):
calls.append((str(path), text.count("\n", 0, match.start()) + 1, match.group(1).strip()))
print("declarations:", declarations)
print("documented calls:", calls)
assert declarations == [""], declarations
assert calls == [
("docs/content/en/docs/documentation/operations/configuration.md", 86, "context")
], calls
print("The API declaration takes zero arguments; the configuration example passes one.")
PYRepository: operator-framework/java-operator-sdk Length of output: 619 Remove the obsolete The example at Documentation fix- .withNamespacesInheritedFromController(context)
+ .withNamespacesInheritedFromController()🤖 Prompt for AI AgentsSources: Coding guidelines, MCP tools |
||
|
|
||
| return EventSourceUtils.nameEventSources(configMapES); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the grammar in the project descriptions.
is an.While ... butconstruction.not yet released as open source.cloud-native.Proposed wording
Also applies to: 75-76, 80-81
🤖 Prompt for AI Agents
Source: Linters/SAST tools