Skip to content

fix: hide incompatible download options - #9089

Open
ulofiai wants to merge 1 commit into
nodejs:mainfrom
ulofiai:fix/issue-8638
Open

fix: hide incompatible download options#9089
ulofiai wants to merge 1 commit into
nodejs:mainfrom
ulofiai:fix/issue-8638

Conversation

@ulofiai

@ulofiai ulofiai commented Aug 6, 2026

Copy link
Copy Markdown

Description

  • hide incompatible installation methods, package managers, platforms, and operating systems instead of rendering them as disabled options
  • exclude AIX from the installation-method selector while keeping it available for official prebuilt binaries
  • add unit coverage for compatibility filtering and explicit exclusions

AIX remains available in the prebuilt selector because Node.js publishes official aix-ppc64 binaries.

Validation

  • git diff --check
  • TypeScript syntax checks for the changed TSX files
  • targeted behavior checks for Linux/Chocolatey and AIX install/prebuilt visibility
  • full pnpm format, pnpm test, and pnpm build were not run because dependencies are not installed in the bundle environment

Related Issues

Fixes #8638.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@ulofiai
ulofiai requested a review from a team as a code owner August 6, 2026 17:46
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Aug 6, 2026 5:47pm

Request Review

@cursor

cursor Bot commented Aug 6, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only download page behavior with targeted filtering; parseCompat remains for tests and under the new helper.

Overview
Download selectors no longer show incompatible choices as disabled entries—they are omitted via a new filterDropdownItems helper that applies existing compatibility rules and drops disabled rows.

Operating system dropdowns can take an optional exclude list. On the main download pages, the install-instructions row uses exclude={['AIX']} so AIX does not appear there, while the prebuilt-binaries row still shows AIX because official aix-ppc64 builds exist.

Unit tests cover compatibility filtering and explicit exclusions.

Reviewed by Cursor Bugbot for commit 19850eb. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove irrelevant dropdown options for installing Node.js rather than disabling them

3 participants