Skip to content

chore(linter): fix import resolver to support condition-only export map - #1136

Open
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:eslint-resolve-conditional-exports
Open

chore(linter): fix import resolver to support condition-only export map#1136
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:eslint-resolve-conditional-exports

Conversation

@Renegade334

@Renegade334 Renegade334 commented Aug 3, 2026

Copy link
Copy Markdown
Member

The override from #1000 only supported pathy export maps, e.g.

{
  ".": "./index.js",
  "./conditional": {
    "import": "./conditional.mjs",
    "default": "./conditional.cjs"
  }
}

rather than

{
  "import": "./index.mjs",
  "default": "./index.cjs"
}

Unblocks #1132.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.31%. Comparing base (4d967bf) to head (4aca985).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   57.32%   57.31%   -0.01%     
==========================================
  Files          53       53              
  Lines       10368    10367       -1     
==========================================
- Hits         5943     5942       -1     
  Misses       4425     4425              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334
Renegade334 force-pushed the eslint-resolve-conditional-exports branch from 87f4197 to 4aca985 Compare August 4, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant