Skip to content

chore: Node.js release key sync #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterDaveHello merged 1 commit into from
Aug 13, 2026
+1 −1
Merged

chore: Node.js release key sync #2606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keys/node.keys
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ CC68F5A3106FF448322E48ED27F5E38D5B0A215F
890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4
C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C
108F52B48DB57BB0CC439B2997B01419BD92F80A
A363A499291CBBC940DD62E41F10027AF002F8B0
655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD
A363A499291CBBC940DD62E41F10027AF002F8B0

@PeterDaveHello PeterDaveHello Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the order changed?

@MikeMcC399 MikeMcC399 Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the order changed?

Correct!

The script update-keys.sh copies the keys in the same order that they are listed in the node > README, where they are sorted in alphabetical order by first name of the signer using the key.

The new key 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD for @sxa was manually added at the end of the list, instead of using the original order. This caused the mismatch between manual update and automatic update.

See also issue #2569