Revert "Merge pull request #62947 from nextcloud/fix/noid/filled-core… - #63012
Merged
Conversation
pringelmann
requested review from
Altahrim,
come-nc,
icewind1991,
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
August 7, 2026 10:07
pringelmann
force-pushed
the
revert/filled-core-action-icons
branch
from
August 7, 2026 10:11
a78ecc6 to
08cbc4e
Compare
artonge
approved these changes
Aug 7, 2026
artonge
left a comment
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Not dramatic to keep as at least it make the view consistent with itself. But approved anyway
pringelmann
enabled auto-merge
August 7, 2026 14:36
come-nc
removed their request for review
August 10, 2026 08:10
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice! :)
Regarding your Deck icon question from #62947 (comment)
Which lib are we using there? tbh I thought the app icon was from Material Design, cc @juliusknorr :D
It’s ok to have the Deck icon there for now. 2 possible alternatives are these, but would be more confusing than beneficial:
jancborchardt
approved these changes
Aug 10, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #62947