PYTHON-5974 - Fix Python 3.12 check for overload test bounds - #2978
Merged
Conversation
NoahStapp
requested review from
blink1073 and
sleepyStick
and removed request for
sleepyStick
August 5, 2026 18:52
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Python version guard in the client backpressure overload timing test so that the “Windows + Python 3.12.x” slack logic correctly applies to all 3.12 micro versions (not just 3.12.0), aligning the test’s bounds with intended behavior across supported runtimes.
Changes:
- Update the version comparison from
sys.version_info <= (3, 12)(which excludes 3.12.1+) tosys.version_info < (3, 13)in the overload timing bound logic. - Apply the same fix to both the asynchronous and generated synchronous variants of the test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_client_backpressure.py | Fix Windows/Python version bound check so 3.12.x is handled correctly in timing slack logic. |
| test/asynchronous/test_client_backpressure.py | Same fix in the async source test to ensure consistent behavior for asyncio timing resolution on 3.12.x. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5974
Changes in this PR
Fix the <= 3.12 check in the test.
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer