Fix BSON iterator safety: sub-doc minimum length check and key_len underflow guard - #2358
Open
dfengliu wants to merge 3 commits into
Open
Fix BSON iterator safety: sub-doc minimum length check and key_len underflow guard#2358dfengliu wants to merge 3 commits into
dfengliu wants to merge 3 commits into
Conversation
…n underflow guard - Add l >= 5 validation for DOCUMENT/ARRAY elements in _bson_iter_next_internal to prevent iterator desync from malformed sub-documents - Add runtime guard in bson_iter_key_len to prevent unsigned underflow on exhausted/invalid iterators in release builds
- test_bson_iter_subdoc_min_len: verify sub-doc minimum length check - test_bson_iter_key_len_after_exhaust: verify key_len return value
…ngo-c-driver into fix/bson-iter-safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two safety issues in the BSON iterator (bson-iter.c):
Changes