feat(react-color-picker): expose headless base APIs - #36517
Open
dmytrokirpa wants to merge 2 commits into
Open
Conversation
|
Pull request demo site: URL |
dmytrokirpa
force-pushed
the
feat/color-picker-headless-base
branch
from
August 5, 2026 13:19
2e9e6cd to
d4cd9c6
Compare
📊 Bundle size report
Unchanged fixtures
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 726 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 897 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 53 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 77 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - Dark Mode.default.chromium.png | 3 | Changed |
vr-tests-react-components/TagPicker 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
Hotell
approved these changes
Aug 5, 2026
Contributor
|
@dmytrokirpa previously we were adding tests to prevent hook regressions, should we add a test before this PR will be merged? |
mainframev
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@fluentui/react-headless-components-previewneeds the color picker behavior and slot state without applying the styled components’ visual-only state. This PR separates that reusable behavior from the styled wrappers so the follow-up PR can compose headless color picker controls without duplicating interaction logic.No visual or behavioral change is intended for the existing
@fluentui/react-color-pickercomponents.Changes
ColorPicker,ColorArea,ColorSlider, andAlphaSlideruse*Base_unstablehooks containing shared slot, input, color, orientation, and change-handling behaviorshapeColorPickercontext-values hook for headless compositionColorChannel@fluentui/react-color-pickerReview guidance
The key boundary is that base hooks own reusable behavior, while the existing component hooks continue to add styled-only state. The existing component API and rendering path remain intact.
Validation
yarn nx lint react-color-pickeryarn nx test react-color-picker(13 suites, 132 tests, 4 snapshots)PR stack
Please review and merge this PR before #36518.