lib Fix Part 5/6 – Function.{apply, bind} - #50453
lib Fix Part 5/6 – Function.{apply, bind}#50453Nathan Shively-Sanders (sandersn) merged 6 commits into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
|
TypeScript Bot (@typescript-bot) run dt |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at 793adeb. You can monitor the build here. Update: The results are in! |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at 793adeb. You can monitor the build here. Update: The results are in! |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at 793adeb. You can monitor the build here. |
|
Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
|
Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing Everything looks good! |
graphemecluster (graphemecluster)
changed the title
|
TypeScript Bot (@typescript-bot) run dt |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based user code test suite on this PR at f435fad. You can monitor the build here. Update: The results are in! |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at f435fad. You can monitor the build here. Update: The results are in! |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the diff-based top-repos suite on this PR at f435fad. You can monitor the build here. Update: The results are in! |
|
Nathan Shively-Sanders (@sandersn) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
Nathan Shively-Sanders (@sandersn) Here are the results of running the top-repos suite comparing Everything looks good! |
|
Hey Nathan Shively-Sanders (@sandersn), the results of running the DT tests are ready. |
|
The webpack failures are just a diff in the error message; the new message is better because there are fewer overloads. |
|
Addresses #52956 I think this looks good enough to ship without a design meeting discussion. One more test though: |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at f435fad. You can monitor the build here. Update: The results are in! |
|
Argh I meant TypeScript Bot (@typescript-bot) test this |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the extended test suite on this PR at f435fad. You can monitor the build here. |
|
Hey Nathan Shively-Sanders (@sandersn), the results of running the DT tests are ready. |
|
Hm, I guess RWC didn't work. I think I'll merge this anyway. |
3 participants
General Information
PR separated out from #49855, because there might be some members expecting smaller PRs. As mentioned in the comments from the big PR, whether to review a single, large PR or 6 smaller PRs is up to the TypeScript Team to decide. I couldn't have found a better way for this; hopefully this will not bring any trouble to the Team.
This PR partially addresses #49773.
For details and the track list about the changes, please see #49773.
Part 5/6, Function.{apply, bind}
The checker is now able to handle tuple with multiple variadics, thus this change.