MT-23076: support api token expiration - #68
Draft
oshchyhol wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The API token endpoints now accept an optional
expires_at. This exposes it in the Java SDK so tokens can be created or reset with an explicit expiration, with no expiration, or with the server default.Changes
TokenExpirationwrapper withTokenExpiration.at(OffsetDateTime)andTokenExpiration.never()factories; it pre-formats the value to an ISO 8601 string (rawOffsetDateTimefields would serialize as numeric timestamps with the SDK's ObjectMapper settings)CreateApiTokenRequest(createApiTokenoperation): optionalexpires_atparam – omitted field keeps the key out of the JSON,never()sends"expires_at": null,at(...)sends the date-time string; the existing(name, resources)constructor still compilesResetApiTokenRequestand aresetApiToken(accountId, id, request)overload (resetApiTokenoperation, request body is optional in the spec); the existing no-arg overload still posts no bodyApiTokenSpecifier(account accesses): addedmasked_token, which the spec defines for theApiTokenspecifierApiTokensExampleHow to test
createApiTokenwithoutexpiresAt– request body has noexpires_atkey; token is created (server assigns the default expiration where the flag is enabled)createApiTokenwithTokenExpiration.never()– request body contains"expires_at": null; created token hasexpiresAtnullcreateApiTokenwithTokenExpiration.at(OffsetDateTime.parse("2027-06-01T00:00:00Z"))– request body contains"expires_at": "2027-06-01T00:00:00Z"; created token returns thatexpiresAtcreateApiTokenwith a past or more-than-5-years-ahead expiration – call throwsHttpClientExceptionwith status 422resetApiToken(accountId, id, new ResetApiTokenRequest(TokenExpiration.never()))– posts{"expires_at": null}; new token never expiresnew CreateApiTokenRequest(name, resources)andresetApiToken(accountId, id)compile as before, the reset posts no body, and both succeed exactly as onmainCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.