TPT-4221: Enhance security of kubeconfig file permission - #919
Open
yec-akamai wants to merge 2 commits into
Open
TPT-4221: Enhance security of kubeconfig file permission#919yec-akamai wants to merge 2 commits into
yec-akamai wants to merge 2 commits into
Conversation
yec-akamai
added
the
improvement
yec-akamai
requested review from
mawilk90 and
zliang-akamai
and removed request for
a team
August 7, 2026 14:53
mawilk90
approved these changes
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens kubeconfig storage by applying restrictive POSIX permissions.
Changes:
- Creates kubeconfig files with mode
0600. - Creates parent directories with mode
0700. - Tests new and existing file permissions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
linodecli/plugins/get-kubeconfig.py |
Adds secure file and directory modes. |
tests/unit/test_plugin_kubeconfig.py |
Tests permission enforcement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+161
to
+165
| file_descriptor = os.open( | ||
| filepath, | ||
| os.O_WRONLY | os.O_CREAT | os.O_TRUNC, | ||
| KUBECONFIG_FILE_MODE, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Ensure that kubeconfig files are now created via 600 instead of 644. Permissions are set atomically at creation, so contents are never briefly world-readable. Pre-existing files with group/other bits set are tightened to 600 on write. The parent directory is created with mode 700.
✔️ How to Test