Use json module for JSON validation in output-cache - #4096
Open
mario-campos wants to merge 1 commit into
Open
Conversation
mario-campos
force-pushed
the
mario-campos/use-json-module
branch
from
August 14, 2026 04:19
1a0c458 to
93d793c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors output-cache validation to use shared JSON schema utilities.
Changes:
- Validates version information using JSON schemas.
- Validates cache entries before accessing the cached version.
Show a summary per file
| File | Description |
|---|---|
src/cli/output-cache.ts |
Replaces manual checks with shared JSON validators. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+133
to
+139
| json.validateSchema( | ||
| { | ||
| version: json.string, | ||
| features: json.optional(json.object({})), | ||
| overlayVersion: json.optional(json.number), | ||
| } as const satisfies json.Schema, | ||
| x, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the included
jsonmodule to improve (make more readable) the validation of the output ofcodeql version.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist