-
Notifications
You must be signed in to change notification settings - Fork 478
Add support for Linux Arm64 runners #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,24 +120,35 @@ test.serial( | |
| const LINKED_BUNDLE_TEST_CASES = [ | ||
| { | ||
| platform: "linux", | ||
| arch: "x64", | ||
| tarSupportsZstd: true, | ||
| expectedBundleName: "codeql-bundle-linux64.tar.zst", | ||
| expectedCompressionMethod: "zstd", | ||
| }, | ||
| { | ||
| platform: "linux", | ||
| arch: "arm64", | ||
| tarSupportsZstd: true, | ||
| expectedBundleName: "codeql-bundle-linux-arm64.tar.zst", | ||
| expectedCompressionMethod: "zstd", | ||
| }, | ||
| { | ||
| platform: "darwin", | ||
| arch: "arm64", | ||
| tarSupportsZstd: true, | ||
| expectedBundleName: "codeql-bundle-osx64.tar.zst", | ||
| expectedCompressionMethod: "zstd", | ||
| }, | ||
|
Comment on lines
135
to
141
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a test for darwin x64?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. makes sense, will do! |
||
| { | ||
| platform: "win32", | ||
| arch: "x64", | ||
| tarSupportsZstd: true, | ||
| expectedBundleName: "codeql-bundle-win64.tar.gz", | ||
| expectedCompressionMethod: "gzip", | ||
| }, | ||
| { | ||
| platform: "linux", | ||
| arch: "x64", | ||
| tarSupportsZstd: false, | ||
| expectedBundleName: "codeql-bundle-linux64.tar.gz", | ||
| expectedCompressionMethod: "gzip", | ||
|
|
@@ -146,6 +157,7 @@ const LINKED_BUNDLE_TEST_CASES = [ | |
|
|
||
| for (const { | ||
| platform, | ||
| arch, | ||
| tarSupportsZstd, | ||
| expectedBundleName, | ||
| expectedCompressionMethod, | ||
|
|
@@ -155,6 +167,7 @@ for (const { | |
| async (t) => { | ||
| const features = createFeatures([]); | ||
| sinon.stub(process, "platform").value(platform); | ||
| sinon.stub(process, "arch").value(arch); | ||
|
|
||
| await withTmpDir(async (tmpDir) => { | ||
| setupActionsVars(tmpDir, tmpDir); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.