Skip to content

fix(auth): request team admin OAuth scope - #1373

Merged
betegon merged 6 commits into
mainfrom
fix/oauth-team-admin-scope
Aug 10, 2026
Merged

fix(auth): request team admin OAuth scope#1373
betegon merged 6 commits into
mainfrom
fix/oauth-team-admin-scope

Conversation

@betegon

@betegon betegon commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Add team:admin to the CLI standard OAuth scope set so authenticated Team Admins can create projects through team-scoped API endpoints. Regenerate the documentation projections owned by the OAuth scope generator.

Existing stored OAuth grants may predate this scope. When an interactive command receives a scope-specific 403, the CLI now offers one refresh with the current standard scopes and retries exactly once. It does not start OAuth for --yes, --dry-run, JSON/non-interactive execution, or effective environment-token auth. Organization policy denials are excluded from scope recovery.

This expands what the token may do; it does not grant Team Admin status to users who do not already have that role.

Test plan

  • pnpm exec vitest run test/lib/oauth.test.ts test/lib/api-scope.test.ts test/lib/scope-recovery.test.ts test/lib/auto-auth.test.ts --coverage=false
  • pnpm exec biome check src/cli.ts src/lib/api-scope.ts src/lib/scope-recovery.ts src/lib/oauth.ts test/lib/api-scope.test.ts test/lib/scope-recovery.test.ts test/lib/oauth.test.ts
  • pnpm exec tsc --noEmit
  • pnpm run check:docs-sections

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure to refresh with the new scope on failure for existing tokens.

@betegon

betegon commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

Thanks for the heads up! I'll check it out

@betegon
betegon force-pushed the fix/oauth-team-admin-scope branch from 1842ad4 to 1e4ac57 Compare August 7, 2026 10:21
@betegon

betegon commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

Implemented the existing-grant path from the review: on a scope-specific 403 from the effective stored OAuth credential, the CLI offers a one-time refresh with the current standard scope set and retries once. Unattended/non-interactive/JSON runs and env-token auth never enter the device flow, and policy denials are not treated as missing OAuth scopes.

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli Ready Ready Preview Aug 10, 2026 8:22pm

Request Review

@betegon
betegon marked this pull request as ready for review August 10, 2026 19:18
@github-actions github-actions Bot added the risk: high PR risk score: high label Aug 10, 2026
Comment thread packages/cli/src/lib/init/tools/create-sentry-project.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d015d41. Configure here.

Comment thread packages/cli/src/lib/init/tools/create-sentry-project.ts Outdated
Only delegate init API errors when interactive OAuth recovery can actually run, so policy and unattended flows keep their actionable fallbacks.
@betegon
betegon merged commit 5a58434 into main Aug 10, 2026
32 checks passed
@betegon
betegon deleted the fix/oauth-team-admin-scope branch August 10, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants