Skip to content

WIP: Migrate dart_skills_lint to google/skills_lint.dart #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
reidbaker-agent wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: Migrate dart_skills_lint to google/skills_lint.dart #9952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef8f0d0
Migrate to skills_lint package
reidbaker Aug 7, 2026
21175ed
Revert unintended analysis_options.yaml modifications
reidbaker Aug 7, 2026
a8883cb
Fix: Restore analysis_options.yaml to upstream/master state
reidbaker Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .agents/skills/dart_skills_lint_ignore.json → .agents/skills/skills_lint_ignore.json
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions tool/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ dependencies:

dev_dependencies:
# TODO(https://github.com/flutter/devtools/issues/9771): Update to published version
dart_skills_lint:
git:
url: https://github.com/flutter/skills
path: tool/dart_skills_lint
ref: 05e5a45fa412ddbdd1d694eee0c71f4bbaea2617
logging: ^1.1.1
skills_lint:
git:
url: https://github.com/google/skills_lint.dart.git
path: packages/skills_lint
ref: main
test: ^1.25.8
2 changes: 1 addition & 1 deletion tool/dart_skills_lint.yaml → tool/skills_lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2026 The Flutter Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
dart_skills_lint:
skills_lint:
rules:
check-relative-paths: error
check-absolute-paths: error
Expand Down
5 changes: 3 additions & 2 deletions tool/test/validate_skills_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

import 'dart:async';
import 'package:dart_skills_lint/dart_skills_lint.dart';

import 'package:logging/logging.dart';
import 'package:skills_lint/skills_lint.dart';
import 'package:test/test.dart';

const String _configFilePath = 'dart_skills_lint.yaml';
const String _configFilePath = 'skills_lint.yaml';

void main() {
test('Validate DevTools Skills', () async {
Expand Down
Loading