Skip to content

Support SimpleCov 1.0 - #140

Open
mateusdeap wants to merge 4 commits into
mainfrom
update-simplecov
Open

Support SimpleCov 1.0#140
mateusdeap wants to merge 4 commits into
mainfrom
update-simplecov

Conversation

@mateusdeap

@mateusdeap mateusdeap commented Jul 28, 2026

Copy link
Copy Markdown
Member
  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description

Adds support for SimpleCov 1.0 in development

I will abide by the code of conduct.

@mateusdeap
mateusdeap requested a review from etagwerker July 28, 2026 13:47

@JuanVqz JuanVqz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There are some deprecations we are raising, probably we cannot fix yet because we are supporting old ruby versions, not that old like next_rails... but I didn't check.

test/test_helper.rb:19: three APIs simplecov 1.0 deprecates, so skunk.yml CI job now prints deprecation noise every run.

Reproduced under 1.0.3:

  1. add_filter lines 19, 20 → Replace with SimpleCov.skip
  2. track_files line 22 → Replace with SimpleCov.cover

Comment thread skunk.gemspec Outdated
Comment thread CHANGELOG.md Outdated
@mateusdeap

Copy link
Copy Markdown
Member Author

LGTM.

There are some deprecations we are raising, probably we cannot fix yet because we are supporting old ruby versions, not that old like next_rails... but I didn't check.

test/test_helper.rb:19: three APIs simplecov 1.0 deprecates, so skunk.yml CI job now prints deprecation noise every run.

I think that, since this is a development dependency, we can update it. Let me fix it up

mateusdeap and others added 2 commits August 10, 2026 14:50
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
Replace deprecated calls to add_filter and track_files for skip and
cover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants