馃悰 Fix mobile sidebar logout leaving login page unclickable - #2285
Closed
Haohua-Sun wants to merge 1 commit into
Closed
馃悰 Fix mobile sidebar logout leaving login page unclickable#2285Haohua-Sun wants to merge 1 commit into
Haohua-Sun wants to merge 1 commit into
Conversation
Haohua-Sun
marked this pull request as ready for review
May 15, 2026 19:23
alejsdev
changed the title
Author
|
The issue is no longer reproducible with the latest dependencies. The underlying Radix cleanup bug has been fixed upstream, so I鈥檓 closing this PR as no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a mobile sidebar interaction issue where logging out from the user menu can leave the login page visible but not clickable.
The logout navigation could run before the nested dropdown menu and mobile sidebar finished closing, leaving dialog/dropdown interaction state active after navigation. The fix closes the dropdown first, then waits for the mobile sidebar close animation before logging out.
Tested by reproducing the issue before the fix and verifying it after the fix on Chrome and Edge on Windows, Android emulator on Windows, and Safari on macOS.