JIT: home dead-at-entry wasm GC register params reported to the GC - #131884
Open
AndyAyersMS wants to merge 2 commits into
Open
JIT: home dead-at-entry wasm GC register params reported to the GC#131884AndyAyersMS wants to merge 2 commits into
AndyAyersMS wants to merge 2 commits into
Conversation
On wasm all on-frame GC locals are reported to the GC untracked (live for the whole method). So even dead GC parameters must be homed on entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89caa9c8-5b0f-4fcc-a8c4-726ac8535110
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
@adamperlin PTAL Fixes a runtime failure in src/tests/JIT/Regression/JitBlue/Runtime_65694/Runtime_65694_2.cs if the test assembly is R2R. |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WASM JIT prolog parameter homing to ensure GC-safe stack slots even when a GC parameter is dead at method entry, aligning register-parameter homing with WASM GC reporting behavior for on-frame GC locals.
Changes:
- Adjusts the “skip homing dead-at-entry params” fast-path to not skip GC parameters that have an on-frame home (
lvOnFrame && HasGCPtr()). - Documents why WASM requires this exception (on-frame GC locals are reported untracked / effectively live for the whole method).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89caa9c8-5b0f-4fcc-a8c4-726ac8535110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wasm all on-frame GC locals are reported to the GC untracked (live for the whole method). So even dead GC parameters must be homed on entry.