direct: add DATABRICKS_BUNDLE_RESOURCE_MAX_WAIT to cap resource waits - #6263
Open
denik wants to merge 4 commits into
Open
direct: add DATABRICKS_BUNDLE_RESOURCE_MAX_WAIT to cap resource waits#6263denik wants to merge 4 commits into
denik wants to merge 4 commits into
Conversation
Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: e8c1e0e
11 interesting tests: 6 KNOWN, 3 SKIP, 2 FAIL
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
…index tests Co-authored-by: Isaac
… index tests Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DATABRICKS_BUNDLE_RESOURCE_MAX_WAIT(in seconds) caps how long deploy and destroy wait for a resource to reach its target state. On expiry the wait is abandoned with a warning rather than failing the deploy: state is saved before the wait, so the resource stays tracked and the next deploy reconciles it.Resources that others depend on keep their full wait, since a dependent must not act on a resource that is not ready. Deletes are capped regardless of dependents, except the delete inside recreate, which has to release the name for the create that follows. Direct engine only.
Why
Vector Search index tests time out in the nightly cloud job. The indexes are DIRECT_ACCESS with no rows, so nothing is actually indexed — the wall clock goes into the backend provisioning a per-index embedding pipeline that the tests never need to observe.
Tests
Unit tests for parsing, the per-resource decision and the wait semantics, including that a genuine failure still fails the deploy and that cancelling the deployment is not swallowed. Acceptance test for the malformed-value error.