Build releases against the FIPS 140-3 validated Go crypto module - #6262
Open
ilyakuz-db wants to merge 2 commits into
Open
Build releases against the FIPS 140-3 validated Go crypto module#6262ilyakuz-db wants to merge 2 commits into
ilyakuz-db wants to merge 2 commits into
Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 066e974
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Build released binaries with
GOFIPS140=v1.0.0. This links the FIPS 140-3 validated GoCryptographic Module into the binary and defaults FIPS 140-3 mode on, so no runtime flag is
needed.
Why
Regulated environments (FedRAMP, IL5) require cryptography to come from a validated module.
This has to be set at build time: the runtime
GODEBUG=fips140=ononly toggles the mode onwhatever module was already linked, so without the build variable, there is no validated module
in the binary and no certificate to cite.
Pinned to a frozen version rather than an alias.
v1.0.0is the version covered by CMVPcertificate
#5247This changes behavior for everyone, not just regulated users: the TLS client offers only
FIPS-approved suites (6 instead of 13, dropping ChaCha20 and CBC)
CI coverage for the FIPS build is added separately in #6193
Tests
Ran the whole unit and acceptance suite against a FIPS build — no failures. Also confirmed all
six release targets (linux/darwin/windows x amd64/arm64) cross-compile with the variable set;
none of the platforms Go excludes from FIPS mode are in our matrix.
This PR was written by Claude Code.