Add supportfor multiple skip/xfail files - #454
Merged
Merged
Conversation
This allows you to specify several files which are combined. For examplea general file plus a platform specific one.
Member
Author
|
I'm not sure who should/can review this, so I requested a review from @ev-br because GitHub suggested it. How do people generally decide on merging (or not) things in this repo? Wait for one review? One thumbs up from Lucas and then self-merge? |
Member
|
Test-driving this PR locally:
The code change LGTM, thank you @betatim |
Member
For the last year or so, it was mostly me self-merging at ad hoc times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to specify several files which are combined. For examplea general file plus a platform specific one.
You can now do something like
pytest --skips-file skips-general.txt --skips-file skips-macos.txt array_api_tests/.There was a difference in line handling between skips and xfails. I unified them to how xfails handles things. The skips lines were only taken
if line.startswith("array_api_tests"). And all other lines were ignored. Now all lines that aren't blank or start with a#are kept. They still have to resolve to valid test IDs, so I think the end result will be the same.This came out of a discussion at data-apis/array-api-strict#240 (comment)