color defs - #285
Open
raphael-goetz wants to merge 2 commits into
Open
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2754090351 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/15856606970/artifacts/out/index.html |
raphael-goetz
force-pushed
the
#282-color-defs
branch
from
August 12, 2026 12:32
1bc240c to
0949178
Compare
nicosammito
requested changes
Aug 12, 2026
nicosammito
left a comment
nicosammito
left a comment
Member
There was a problem hiding this comment.
We are missing functions asHsl and fromHsl
| name(en_US = "Color"), | ||
| display_message(en_US = "Color"), | ||
| alias(en_US = "color;colour;grb;hsv;hsl;hex"), | ||
| type_string = "{ hue: number; saturation: number; lightness: number; alpha: number }", |
| } | ||
|
|
||
| /// Converts RGB (0..=255) + alpha (0..=1) into HSLA (hue 0..360, saturation/lightness 0..100, alpha 0..1). | ||
| fn rgb_to_hsl(red: f64, green: f64, blue: f64) -> (f64, f64, f64) { |
Member
There was a problem hiding this comment.
missing optional alpha channel
| } | ||
|
|
||
| /// Converts HSLA (hue 0..360, saturation/lightness 0..100) into RGB (0..=255). | ||
| fn hsl_to_rgb(hue: f64, saturation: f64, lightness: f64) -> (f64, f64, f64) { |
Member
There was a problem hiding this comment.
missing optional alpha channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #282