Skip to content

Fix regional partner form alignment - #74472

Merged
levadadenys merged 3 commits into
stagingfrom
rebrand/regional-partner-form-alignment
Aug 13, 2026
Merged

Fix regional partner form alignment#74472
levadadenys merged 3 commits into
stagingfrom
rebrand/regional-partner-form-alignment

Conversation

@levadadenys

@levadadenys levadadenys commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Before:
Знімок екрана 2026-08-07 о 11 23 34

After:
Знімок екрана 2026-08-07 о 11 22 53

Summary

This is part of the Rebrand project. The Grade Level(s) and Your role controls in the regional partner contact form bypassed the Bootstrap grid wrapper used by the other form fields, which left the two groups horizontally misaligned.

This change gives both groups a shared 15px offset, matching the form grid gutter. Their labels and controls now align with the rest of the form without changing field semantics or interaction.

Testing

  • Manually verified locally by the reporter.
  • yarn test:unit test/unit/code-studio/pd/regional_partner_mini_contact/RegionalPartnerMiniContactTest.jsx — 6 tests pass.
  • git diff --check
  • ./tools/hooks/pre-commit

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 074ce06a53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes visual alignment in the regional partner mini contact form (part of the Rebrand project) by ensuring the “Grade Level(s)” and “Your role” controls align with the Bootstrap-based gutter used by the rest of the form fields.

Changes:

  • Introduces a new optionFieldGroup SCSS module style to apply consistent left offset and label styling for the option-style controls.
  • Updates the Grade Level(s) and Your role wrappers to use optionFieldGroup instead of fieldGroup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/src/code-studio/pd/regional_partner_mini_contact/regionalPartnerMiniContact.module.scss Adds optionFieldGroup styling to align option controls with the form gutter.
apps/src/code-studio/pd/regional_partner_mini_contact/RegionalPartnerMiniContact.jsx Applies the new wrapper class to the Grade Level(s) and Your role sections.

@levadadenys
levadadenys merged commit f0b6b53 into staging Aug 13, 2026
8 checks passed
@levadadenys
levadadenys deleted the rebrand/regional-partner-form-alignment branch August 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants