-
Notifications
You must be signed in to change notification settings - Fork 466
feat(ui): stacked dialog motion #9432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+466
−38
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0d8ec9a
feat(ui): stacked dialog motion
maxyinger f061203
feat(ui): dim the surface beneath a stacked dialog
maxyinger c45a51f
feat(ui): separate a stack from a nested dialog
maxyinger 46a422b
feat(ui): hold the recede through a stacked dialog's exit
maxyinger 6f52190
feat(ui): drop the stacked-dialog exit stagger
maxyinger 50a4f46
feat(ui): shorten the sheet fade for a stacked prompt
maxyinger 83c852e
feat(ui): demo a vetoed close in the nested dialog story
maxyinger 4932dd5
fix(ui): address review feedback on #9432
maxyinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Add a release entry for
@clerk/ui.Lines 1-2 create an empty changeset, but this PR adds user-visible dialog behavior in
packages/ui. Without a package entry, the feature can ship without an@clerk/uiversion bump or changelog entry.Proposed changeset
As per coding guidelines, “Use Changesets for version management and changelogs.” Based on learnings, empty changesets are acceptable only for documentation-only or non-published-package changes.
📝 Committable suggestion
🤖 Prompt for AI Agents
Sources: Coding guidelines, Learnings