Refactor meminfo - #4698
Conversation
|
I get the intention of the issue and the improvement approach but this changes the behavior of reading these values from a cached property to re-reading it every time which I don't thing we want. |
|
I agree with avoiding re-reading and I am glad you are looking out for that. As In the current design, which uses I would also recommend against force caching something that contains dynamic values. As always, thank you for reviewing. |
|
If there are other iterations coming then I don't mind gettting this in. I do agree that the dynamic values shouldn't be cached but in this case they are hardware values from the underlying system so I think it'd be a fair assumption to say they will never change. |
|
|
Part of #4149